Use the correct build path suffix across all platforms #9353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows self hosted |
Contributor
Author
|
@swift-ci test windows self-hosted |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
1 similar comment
Contributor
Author
|
@swift-ci test windows |
Now it's correct everywhere, not only for macOS, Windows, and Linux. Main motivation was for FreeBSD, and will also work for Android, Wasm, iOS, etc.
jakepetroules
force-pushed
the
eng/PR-build-path-suffix
branch
from
138a44f to
099248c
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
owenv
approved these changes
Nov 13, 2025
Contributor
Author
|
@swift-ci test windows |
bkhouri
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's correct everywhere, not only for macOS, Windows, and Linux.
Main motivation was for FreeBSD, and will also work for Android, Wasm, iOS, etc.